Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom timeout values #7

Closed
pouriyajamshidi opened this issue May 8, 2022 · 2 comments · Fixed by #130
Closed

Custom timeout values #7

pouriyajamshidi opened this issue May 8, 2022 · 2 comments · Fixed by #130
Labels
enhancement New feature or request feature request feature request good first issue Good for newcomers

Comments

@pouriyajamshidi
Copy link
Owner

Summary

Currently tcping is having a hard-coded timeout value of 1 second. Being able to change this value through a flag can be useful for some scenarios but requires a major refactoring.
@pouriyajamshidi pouriyajamshidi added the enhancement New feature or request label May 8, 2022
@mshedsilegx
Copy link

I would vote for this to be implemented as a core feature. 1s might be too aggressive on high latency links.

@pouriyajamshidi pouriyajamshidi added the feature request feature request label Jul 31, 2023
@pouriyajamshidi pouriyajamshidi mentioned this issue Aug 5, 2023
Closed
@pouriyajamshidi pouriyajamshidi added the good first issue Good for newcomers label Aug 5, 2023
This was referenced Aug 8, 2023
Closed
Merged
@pouriyajamshidi
Copy link
Owner Author

@mshedsilegx it is implemented now. Although not released yet. but you can compile from this repo to get the -t option, specifying the custom timeout value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature request feature request good first issue Good for newcomers
Projects
TCPING
Status: Done
Milestone
No milestone
2 participants
@mshedsilegx @pouriyajamshidi