Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

GetDotByDotOrId will not check the validity of the id #20

Open
sinabakh opened this issue Jul 13, 2016 · 2 comments
Open

GetDotByDotOrId will not check the validity of the id #20

sinabakh opened this issue Jul 13, 2016 · 2 comments

Comments

@sinabakh
Copy link
Contributor

Abstraction Layer's GetDotByDotOrId will not check if the given id number exist on graph or no.

@sinabakh
Copy link
Contributor Author

@pmkary It seems to be a bigger problem than it appears.
Cause we can't simply return False since it breaks the design pattern.

In other hands it seems GetDotByNumberId will return an empty Dot if no dot is found.
What really happens when it return the empty Dot ? and is there an easy way to check if it returned an empty Dot ?

@pouyakary
Copy link
Owner

@sinabakh that's interesting...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants