Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing call to InstrEndLoop #11

Closed
tvondra opened this issue Nov 4, 2016 · 1 comment
Closed

missing call to InstrEndLoop #11

tvondra opened this issue Nov 4, 2016 · 1 comment
Labels

Comments

@tvondra
Copy link

tvondra commented Nov 4, 2016

pgqs_ExecutorEnd gets called before regular ExecutorEnd, which means the instrumentation may not be finalized - there may still be data from the last loop in some of the nodes. pgqs_collectNodeStats needs to do something like this:

if (planstate->instrument)
	InstrEndLoop(planstate->instrument);

similarly to ExplainNode().

@rjuju
Copy link
Member

rjuju commented Nov 5, 2016

Indeed. I wasn't aware of that, thank a lot for the report and the fix! It's fixed in 7ad33fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants