Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUXE-227] Add alignment properties to tables #1208

Merged
merged 10 commits into from
Nov 19, 2020
Merged

Conversation

maddiemc01
Copy link
Contributor

@maddiemc01 maddiemc01 commented Nov 11, 2020

Screenshots

Screen Shot 2020-11-13 at 3 41 56 PM
Screen Shot 2020-11-13 at 3 42 03 PM
Screen Shot 2020-11-13 at 3 42 17 PM
Screen Shot 2020-11-13 at 3 42 22 PM
Screen Shot 2020-11-13 at 3 42 31 PM

Breaking Changes

it does not remove (nor add) props. it adds a custom attribute and doesn't interfere with the class name

Runway Ticket URL

https://nitro.powerhrg.com/runway/backlog_items/NUXE-227
[INSERT URL]

How to test this

see below

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • URGENCY Please select a release milestone
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
    since this does not add any props or change the class name, no new spec test were added. Did play around and see if they can be used with combined with each other and it does seem to work
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

The normal release cut off deadline is 3p EDT each week. Please reach out to the release team if you have an urgent request or need a release off cycle.

@maddiemc01 maddiemc01 requested a review from a team as a code owner November 11, 2020 20:58
@maddiemc01 maddiemc01 added the wip label Nov 12, 2020
@maddiemc01 maddiemc01 added the enhancement New Features, Props, & Variants (USED IN CHANGELOG) label Nov 12, 2020
@bh247484 bh247484 added the milano 20 MAX - Deploy this PR to a review environment via Milano label Nov 12, 2020
@maddiemc01 maddiemc01 removed the wip label Nov 12, 2020
@jasperfurniss jasperfurniss merged commit 5205dbe into v7.8.0 Nov 19, 2020
@jasperfurniss jasperfurniss deleted the TablesAlignProp branch November 19, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants