Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data, aria, & name props to RichTextEditor #1352

Merged
merged 2 commits into from
Feb 11, 2021

Conversation

coleerikson
Copy link
Contributor

@coleerikson coleerikson commented Feb 8, 2021

Screens

richtext-attributes

Breaking Changes

No - This add additional props with optional props.

Runway Ticket URL

NUXE-447

How to test this

Has tests, attributes in new example as well.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • URGENCY Please select a release milestone
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.

@coleerikson coleerikson added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Feb 8, 2021
@coleerikson coleerikson added this to the 8.1.0 milestone Feb 8, 2021
@coleerikson coleerikson requested a review from a team as a code owner February 8, 2021 20:51
@jasoncypret jasoncypret modified the milestones: 8.1.0, 8.0.0 Feb 11, 2021
@jasoncypret
Copy link
Member

Waiting on Milano...

@jasoncypret jasoncypret added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Feb 11, 2021
@jasoncypret jasoncypret merged commit fe8900c into master Feb 11, 2021
@jasoncypret jasoncypret deleted the nuxe-448/richtext-props branch February 11, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano not ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants