Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken styles in multiple users stacked + pill accessibility, badge alignment, & menu re-organization #1488

Merged
merged 1 commit into from
May 10, 2021

Conversation

jasoncypret
Copy link
Member

@jasoncypret jasoncypret commented May 10, 2021

  1. Removed H3 from pill (accessibility)
  2. Restructure Menu + alphabetize
  3. Fixed broken CSS in Multiple Stacked Users (CSS specificity)
  4. Fixed alignment of badge text
  5. Corrected badge from breaking to two lines

Screens

image
(1) ^

image
(2) ^

image
(3) ^

image
(4) ^

image
(5) ^

Breaking Changes

No

Runway Ticket URL

https://nitro.powerhrg.com/runway/backlog_items/NUXE-533
https://nitro.powerhrg.com/runway/backlog_items/NUXE-157

How to test this

See screens and compare with the latest on Production. This is safe to merge immediately agyer review.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • URGENCY Please select a release milestone
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

The normal release cut off deadline is 3p EDT each week. Please reach out to the release team if you have an urgent request or need a release off cycle.

@jasoncypret jasoncypret added the milano 20 MAX - Deploy this PR to a review environment via Milano label May 10, 2021
@jasoncypret jasoncypret requested a review from a team May 10, 2021 22:01
@jasoncypret jasoncypret changed the title Fixed CSS in Mult Fixed pills, badge, multi stacked, and menu Fixed broken styles in multiple users stacked + pill accessibility, badge alignment, & menu re-organization May 10, 2021
@jasoncypret jasoncypret added the bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) label May 10, 2021
@jasoncypret jasoncypret changed the title Fixed broken styles in multiple users stacked + pill accessibility, badge alignment, & menu re-organization [NUXE-533] [NUXE-157] Fixed broken styles in multiple users stacked + pill accessibility, badge alignment, & menu re-organization May 10, 2021
@jasoncypret jasoncypret changed the title [NUXE-533] [NUXE-157] Fixed broken styles in multiple users stacked + pill accessibility, badge alignment, & menu re-organization Fixed broken styles in multiple users stacked + pill accessibility, badge alignment, & menu re-organization May 10, 2021
@jasoncypret jasoncypret linked an issue May 10, 2021 that may be closed by this pull request
Copy link
Contributor

@jasperfurniss jasperfurniss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jasperfurniss jasperfurniss requested review from jasperfurniss and removed request for jasperfurniss May 11, 2021 00:14
@thestephenmarshall thestephenmarshall removed the milano 20 MAX - Deploy this PR to a review environment via Milano label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Stacked User Kit - no longer fixed size [NUXE-533]
4 participants