Add Background Colors to the Card Kit #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THElvan
added
enhancement
THElvan
force-pushed
the
background_colors_in_cards
branch
from
82e34ed
to
c6c5564
Compare
|
Yay Ivan! |
|
First PR lets gooooo 🥶 |
jasoncypret
requested changes
Nov 18, 2021
There was a problem hiding this comment.
Look great just a couple of things.
- make the class more specific
- you have rubocop, Gemfile, & gemspec updates. I don't think those are needed for this PR. You should reset those files from master and commit back up. We should see 3 fewer files.
- Lets remove that Dark classname. If that is added for a reason work with Jon or Jasper to correct the issue.
playbook/app/pb_kits/playbook/pb_card/docs/_card_background.html.erb
Outdated
Show resolved
Hide resolved
playbook/app/pb_kits/playbook/pb_card/docs/_card_background.html.erb
Outdated
Show resolved
Hide resolved
playbook/app/pb_kits/playbook/pb_card/docs/_card_background.html.erb
Outdated
Show resolved
Hide resolved
playbook/app/pb_kits/playbook/pb_card/docs/_card_background.jsx
Outdated
Show resolved
Hide resolved
playbook/app/pb_kits/playbook/pb_card/docs/_card_background.jsx
Outdated
Show resolved
Hide resolved
THElvan
force-pushed
the
background_colors_in_cards
branch
from
0023d70
to
0ff649a
Compare
jasoncypret
approved these changes
Nov 18, 2021
kre8sions
added
Ready for Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
Breaking Changes
No. This change just adds a background prop to the Card Kit.
Runway Ticket URL
https://nitro.powerhrg.com/runway/backlog_items/PLAY-3
How to test this
Added tests for classname when a background is passed.
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.