Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playbook Webpack Cleanup + Simplified Setup #1672

Merged
merged 13 commits into from
Dec 2, 2021
Merged

Playbook Webpack Cleanup + Simplified Setup #1672

merged 13 commits into from
Dec 2, 2021

Conversation

thestephenmarshall
Copy link
Contributor

@thestephenmarshall thestephenmarshall commented Nov 19, 2021 •
edited
Loading

Screens

  • Fixes duplicated compilation
  • Removes extraneous playbook-react.js
  • Cleans up compiler output babel warnings/info
  • Updates ruby, yarn and node versions to latest allowed

Screen Shot 2021-11-19 at 12 14 37 PM

Screen Shot 2021-11-19 at 12 14 41 PM

Breaking Changes

None

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@thestephenmarshall thestephenmarshall requested a review from a team as a code owner November 19, 2021 18:17
@thestephenmarshall thestephenmarshall added milano 20 MAX - Deploy this PR to a review environment via Milano react labels Nov 19, 2021
@thestephenmarshall thestephenmarshall self-assigned this Nov 19, 2021
smkopp92
smkopp92 approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@smkopp92 smkopp92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉 This is great! Good work 🎉 🎉 🎉

setup.sh Show resolved Hide resolved
playbook/babel.config.js Show resolved Hide resolved
@app-milano app-milano bot temporarily deployed to pr1672 November 19, 2021 18:37 Inactive
@app-milano app-milano bot temporarily deployed to pr1672 November 22, 2021 15:23 Inactive
@app-milano app-milano bot temporarily deployed to pr1672 December 1, 2021 17:52 Inactive
@thestephenmarshall thestephenmarshall merged commit 7afcfe8 into master Dec 2, 2021
@thestephenmarshall thestephenmarshall deleted the playbook-cleanup-simplify branch December 2, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasoncypret jasoncypret jasoncypret approved these changes

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@smkopp92 smkopp92 smkopp92 approved these changes

Assignees

@thestephenmarshall thestephenmarshall

Labels
milano 20 MAX - Deploy this PR to a review environment via Milano react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thestephenmarshall @jasoncypret @jasperfurniss @smkopp92