Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Custom Color Options for Line Graph Kit #1693

Merged
merged 4 commits into from
Dec 8, 2021

Conversation

pauljpark
Copy link
Contributor

Screens

Screen Shot 2021-12-08 at 12 15 17 PM

Breaking Changes

[Yes/No (Explain)]

Runway Ticket URL

https://nitro.powerhrg.com/runway/backlog_items/PLAY-12

How to test this

Pass prop colors to line graph kit and choose from data colors data-1 | data-2 | data-3 | data-4 | data-5 | data-6 | data-7 | data-8. Place color option(s) in array.

Examples:

React
colors={['data-1', 'data-2']}

Rails
colors: ['data-1', 'data-2']

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@pauljpark pauljpark added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Needs Review labels Dec 8, 2021
@pauljpark pauljpark requested a review from a team as a code owner December 8, 2021 17:22
@pauljpark pauljpark merged commit 5fe9b16 into master Dec 8, 2021
@pauljpark pauljpark deleted the Add-color-options-for-Line-Graph-kit branch December 8, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants