Create React Line Height Partial #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed flow and Renamed file * Updated Types * Removed JSX file extentions from imports * Fix syntax error * Fix tests Co-authored-by: Erica Winne <erica.winne@powerhrg.com>
* Started Converting * Rename file to TSX and Updated types * Added/Joined & GlobalProps * Merge Master * Changed back default blank string Co-authored-by: Erica Winne <erica.winne@powerhrg.com>
…1849) * Rendered rough example in browser * Section separator between props and values * Added pills and continued to change styling * Fixed width of cards * Fixed flexitem alignment * Added title and body kits * Fixed more styling * Changed out background kit to fix border radius * Fixed border radius * Fixed border radius on other templates * Updated caption card * Fixed title margins * Corrected camelcase in pills * Three templates for visual guidelines * Fixed syntax error * Fixed syntax again * Testing client-side code example colorization * Use Rouge to format code examples * Template Complete Co-authored-by: Stephen Marshall <smarshall1980@gmail.com>
THElvan
added
the
milano
thestephenmarshall
force-pushed
the
master
branch
3 times, most recently
from
8ff76c1
to
e79ba3d
Compare
thestephenmarshall
requested changes
May 12, 2022
thestephenmarshall
approved these changes
May 12, 2022
thestephenmarshall
changed the title
thestephenmarshall
added
the
Ready for Release
thestephenmarshall
force-pushed
the
master
branch
2 times, most recently
from
4755d3c
to
9a62f6e
Compare
THElvan
removed
the
milano
…e-height-partial-to-react
…e-height-partial-to-react
…e-height-partial-to-react
thestephenmarshall
deleted the
PLAY-167-switch-line-height-partial-to-react
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
Screen.Recording.2022-05-11.at.2.20.59.PM.mov
Breaking Changes
No. No logic changes and just added it to the
visual_guidelines_react.Runway Ticket URL
PLAY-167
How to test this
[INSERT TESTING DETAILS]
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.