[Play-450] Charts/Graphs kits legend position #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art.js as well as to the line_graph kit for both react and rails
…d the five props to the rails and react circle chart kits
Israel-Molestina
added
enhancement
…nd one for x and y offset for the bar graph
Israel-Molestina
added
milano
nidaqg
approved these changes
Nov 4, 2022
…being passed correctly and update the doc examples for legend position
…eing passed correctly and update the doc examples for legend position
jasperfurniss
approved these changes
Nov 14, 2022
jasperfurniss
added
the
Ready for Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
Old
New
Breaking Changes
NO
Runway Ticket URL
Runway TIcket
How to test this
You can test this by using each new prop and making sure each value has the intended outcome
Also please look at the new doc examples for both rails and react in the bar graph, circle chart and line graph kits to make sure they are easy to read and digest.
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.