Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Play-450] Charts/Graphs kits legend position #2171

Merged
merged 15 commits into from Nov 14, 2022
Merged

[Play-450] Charts/Graphs kits legend position #2171

merged 15 commits into from Nov 14, 2022

Commits on Nov 3, 2022

  1. added the five legend props to the default setupChart method in pb_ch… 

    …art.js as well as to the line_graph kit for both react and rails
    @Israel-Molestina
    Israel-Molestina committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    f21d9de View commit details
    Browse the repository at this point in the history

  2. added spec test for line_graph

    @Israel-Molestina
    Israel-Molestina committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    3e3d970 View commit details
    Browse the repository at this point in the history

  3. added five legend props to bar_graph

    @Israel-Molestina
    Israel-Molestina committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    566c509 View commit details
    Browse the repository at this point in the history

  4. added spec tests for bar_graph new props

    @Israel-Molestina
    Israel-Molestina committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    41551ab View commit details
    Browse the repository at this point in the history

  5. added the five props tot the setupPieChart method in pb_chat and adde… 

    …d the five props to the rails and react circle chart kits
    @Israel-Molestina
    Israel-Molestina committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    69ebdbc View commit details
    Browse the repository at this point in the history

  6. created new doc in circle_chart to showcase the five new props

    @Israel-Molestina
    Israel-Molestina committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    1f9a015 View commit details
    Browse the repository at this point in the history

  7. added a new doc to bar_graph to showcase the 5 new legend position props

    @Israel-Molestina
    Israel-Molestina committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    977ce30 View commit details
    Browse the repository at this point in the history

  8. created new doc for line_graph to showcase 5 new legend position props

    @Israel-Molestina
    Israel-Molestina committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    51326bb View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. refactored the documentation files per feedback

    @Israel-Molestina
    Israel-Molestina committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    9e81768 View commit details
    Browse the repository at this point in the history

  2. refactred the doc examples to show one for alignmnet one for layout a… 

    …nd one for x and y offset for the bar graph
    @Israel-Molestina
    Israel-Molestina committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    7bfcf2c View commit details
    Browse the repository at this point in the history

  3. added doc examples in circle chart for alignment, layout, and x and y… 

    … offset
    @Israel-Molestina
    Israel-Molestina committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    3b6f1d2 View commit details
    Browse the repository at this point in the history

  4. added doc examples to line graph for new legend props

    @Israel-Molestina
    Israel-Molestina committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    f5e4074 View commit details
    Browse the repository at this point in the history

  5. fixed but in rails version of line graph where subtitle prop was not … 

    …being passed correctly and update the doc examples for legend position
    @Israel-Molestina
    Israel-Molestina committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    ed30937 View commit details
    Browse the repository at this point in the history

  6. fixed bug in rails version of bar graph where subtitle prop was not b… 

    …eing passed correctly and update the doc examples for legend position
    @Israel-Molestina
    Israel-Molestina committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    24beb20 View commit details
    Browse the repository at this point in the history

  7. update the doc examples for legend position

    @Israel-Molestina
    Israel-Molestina committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    304db78 View commit details
    Browse the repository at this point in the history