JS Form kit validation #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestephenmarshall
force-pushed
the
js-form-kit-validation
branch
2 times, most recently
from
9b8e52b
to
d073d15
Compare
thestephenmarshall
changed the title
thestephenmarshall
force-pushed
the
js-form-kit-validation
branch
from
d073d15
to
1468e91
Compare
thestephenmarshall
force-pushed
the
js-form-kit-validation
branch
2 times, most recently
from
b25650b
to
2da5e09
Compare
jasoncypret
approved these changes
Jan 24, 2020
thestephenmarshall
force-pushed
the
js-form-kit-validation
branch
from
2da5e09
to
71e0304
Compare
jasoncypret
pushed a commit
that referenced
this pull request
Jan 25, 2020
jasoncypret
pushed a commit
that referenced
this pull request
Jan 25, 2020
jasoncypret
added a commit
that referenced
this pull request
Jan 25, 2020
* Kit Error States (#554) * Update CHANGELOG.md * [BOLT-49] Modernize and improve the Currency kit (#565) * Modernize rails currency compoennt * Fix sass code indentation * Update changelog file * Shadow Shallow, Default & Dark Deprecation (#568) * Shadow Shallow & Default Depraction * Selectable Card shadow changed to deep * Card spec and utilities slim updated * Update CHANGELOG.md * JS Form kit validation (#567) * Popover Kit (#569) * WIP Popover Rails * Docs Updated * Added Spec Tests * PR Changes Requested * Changed buttonId prop name * Followed Naming Conventions * Followed Naming Conventions * Followed Naming Conventions * Update CHANGELOG.md Co-authored-by: Jason Cypret <jason@jasoncypret.com> * version bump Co-authored-by: Stephen Marshall <smarshall1980@gmail.com> Co-authored-by: Diego Borges <drborges.cic@gmail.com> Co-authored-by: Megan Trimble <53874143+megantrimble@users.noreply.github.com> Co-authored-by: Jasper Furniss <jasperfurniss@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runway Ticket URL
https://nitro.powerhrg.com/runway/backlog_items/NUX-560
Breaking Changes
None
How to Ninja test this (screenshots are really helpful)
View dev docs page
Checklist:
[Unreleased]section to every functionalityADDED/CHANGED/DEPRECATED/REMOVED/FIXED