Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

Build on ruby 3.1.2 #7

Merged
merged 5 commits into from
May 20, 2022
Merged

Build on ruby 3.1.2 #7

merged 5 commits into from
May 20, 2022

Conversation

xjunior
Copy link
Contributor

@xjunior xjunior commented May 19, 2022

No description provided.

@xjunior xjunior requested a review from a team as a code owner May 19, 2022 22:28
@benlangfeld
Copy link
Member

@xjunior
Copy link
Contributor Author

xjunior commented May 20, 2022

@benlangfeld that is the oldest version supported:

Users may let RuboCop know the oldest version of Ruby which your project supports with:

AllCops:
  TargetRubyVersion: 2.5

@benlangfeld
Copy link
Member

@benlangfeld that is the oldest version supported:

Users may let RuboCop know the oldest version of Ruby which your project supports with:

AllCops:
  TargetRubyVersion: 2.5

Should we recommend that consuming projects override this in our docs?

@xjunior
Copy link
Contributor Author

xjunior commented May 20, 2022

@benlangfeld that is the oldest version supported:

Users may let RuboCop know the oldest version of Ruby which your project supports with:

AllCops:
  TargetRubyVersion: 2.5

Should we recommend that consuming projects override this in our docs?

Makes sense to me. And actually, remove this from this project?

@benlangfeld
Copy link
Member

@benlangfeld that is the oldest version supported:

Users may let RuboCop know the oldest version of Ruby which your project supports with:

AllCops:
  TargetRubyVersion: 2.5

Should we recommend that consuming projects override this in our docs?

Makes sense to me. And actually, remove this from this project?

I don't mind specifying a minimum version here. We might want to also specify it in the gemspec.

@xjunior
Copy link
Contributor Author

xjunior commented May 20, 2022

@benlangfeld that is the oldest version supported:

Users may let RuboCop know the oldest version of Ruby which your project supports with:

AllCops:
  TargetRubyVersion: 2.5

Should we recommend that consuming projects override this in our docs?

Makes sense to me. And actually, remove this from this project?

I don't mind specifying a minimum version here. We might want to also specify it in the gemspec.

I think it makes sense to leave this to the client project because this enables/disables some cops, and feels weird the lining lib establishing a minimum version. What do you think?

@benlangfeld
Copy link
Member

I think this lib will have a minimum Ruby version it will work on whether we specify it explicitly or not. I don't really mind either way, but I do think we should recommend that users specify something in their apps regardless.

@xjunior xjunior merged commit 04bd3fa into main May 20, 2022
@xjunior xjunior deleted the ruby-3.1.2 branch May 20, 2022 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants