Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add episode change support #2

Closed
PowerSlime opened this issue Aug 24, 2019 · 1 comment
Closed

Add episode change support #2

PowerSlime opened this issue Aug 24, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@PowerSlime
Copy link
Owner

PowerSlime commented Aug 24, 2019

On receiving kodik_player_current_episode pause player (already done) and emit socket message. Also implement this method in player.

On receiving changeEpisode from socket player's changeEpisode should be triggered.

Kodik docs

change_episode method. Should be sended by postMessage (player._sendPostMessage method)

{
  method: "change_episode",
  season: 5,
  episode: 3
}

Example: player._sendPostMessage("change_episode", { season: 5, episode: 3 }, false). Should be done like seek method, with possibility to not send socket message.

Requirements:

Method name: changeEpisode
Example: player.methods.changeEpisode({ season, episode })

@PowerSlime PowerSlime added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 24, 2019
@PowerSlime
Copy link
Owner Author

For more info about socket's endpoints PowerSlime/sync-watch-server#1

@PowerSlime PowerSlime added enhancement New feature or request and removed help wanted Extra attention is needed labels Aug 24, 2019
@PowerSlime PowerSlime added this to the v2.0.0 milestone Aug 24, 2019
PowerSlime added a commit that referenced this issue Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant