-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IIDM extension design issue #828
Comments
Maybe |
Ok for |
What's the relationship between |
is the newExtensionAdder added to the Extandable interface ? |
newExtensionAdder() impl will look for a ExtensionAdderFactory plugin matching criteria and then call ExtensionAdderFactory.createAdder. |
yes |
A similar design has been done in AFS, for instance: ImportedCase importedCase = folder.fileBuilder(ImportedCaseBuilder.class)
.withCase(aCase)
.withParameter("param1", "true")
.withParameters(ImmutableMap.of("param2", "1"))
.build(); |
Resolved by #1152 |
Do you want to request a feature or report a bug?
A bug or at least a design flaw
What is the current behavior?
Network model has been split in API and implementation part so that we can have different implementations for different purposes but a single API. So processing on top of network api like merging, import, export, simulation could be reused for any implementation.
Unfortunately this has not been done for extensions.
Example to add an XNode extension to a dangling line:
So here we directly instantiate the extension and add it the dangling line.
What about if DanglingLine is not coming from in memory default implementation but from a persistent connected to a db one?
As for network API extension could be split into API and implementations and provide a builder like way to create it in order to hide the instantiation.
And depending of impl, correct Adder will be used. For this we could imagine a plugin archi like
To allow alternative IIDM implementation to use extensions.
Please tell us about your environment:
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, spectrum, etc)
(if a question doesn't apply, you can delete it)
The text was updated successfully, but these errors were encountered: