Add apparent power attribute (ratedS) on transformers in IIDM #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miovd
requested changes
Mar 3, 2020
There was a problem hiding this comment.
After a discussion with our experts, it seems more logical to have ratedS linked to ends of transformers for ThreeWindingsTransformer
Hence, instead of being in the ThreeWindingsTransformer, please put the ratedS attribute on ThreeWindingsTransformer.Leg
More general remarks:
- don't forget default implementation when adding methods in interfaces to prevent breaking changes
e.g.
default double getRatedS1() {
throw new UnsupportedOperationException();
}- contrary to
ratedSin generators, apparent power is optional for transformers: it can beNaN. The only check should be to ensure it is strictly positive if notNaN
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
…gsTransformerXML Signed-off-by: Thomas ADAM <tadam@silicom.fr>
…ormer to Leg Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
miovd
reviewed
Mar 4, 2020
| @@ -24,6 +24,8 @@ | |||
|
|
|||
| TwoWindingsTransformerAdder setRatedU2(double ratedU2); | |||
|
|
|||
| TwoWindingsTransformerAdder setRatedS(double ratedS); | |||
|
|
||
| protected static void readRatedS(String name, NetworkXmlReaderContext context, RatedSConsumer consumer) { | ||
| double ratedS = XmlUtil.readOptionalDoubleAttribute(context.getReader(), name); | ||
| consumer.accept(ratedS); |
There was a problem hiding this comment.
Rather than using a custom interface, you can use DoubleConsumer here and delete RatedSConsumer
miovd
added
PR: waiting-for-correction
Doc needed
and removed
PR: corrected
PR: review-ongoing
labels
…oubleConsumer Signed-off-by: Thomas ADAM <tadam@silicom.fr>
miovd
approved these changes
Mar 4, 2020
mathbagu
reviewed
Mar 5, 2020
| @@ -137,15 +146,15 @@ public ThreeWindingsTransformerAdderImpl add() { | |||
| if (legNumber == 1) { | |||
| voltageLevel1 = checkAndGetVoltageLevel(); | |||
| terminal1 = checkAndGetTerminal(); | |||
| leg1 = new LegImpl(r, x, g, b, ratedU, legNumber); | |||
| leg1 = new LegImpl(r, x, g, b, ratedU, legNumber, ratedS); | |||
There was a problem hiding this comment.
Maybe we should put ratedS close to ratedU?
| public void invalidRatedS() { | ||
| ThreeWindingsTransformer transformer = createThreeWindingsTransformer(); | ||
| ThreeWindingsTransformer.Leg leg1 = transformer.getLeg1(); | ||
| leg1.setRatedS(Double.NaN); |
There was a problem hiding this comment.
Seems useless to set ratedS to NaN.
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
|
Kudos, SonarCloud Quality Gate passed!
|
tadam50
added
PR: corrected
PR: waiting-for-info-reviewer
and removed
PR: waiting-for-info-reviewer
labels
miovd
added
PR: ready-to-be-merged
and removed
Doc needed
PR: corrected
PR: waiting-for-info-reviewer
labels
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restfix #1144
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
Other information: