Add flag for enabling node moving in network area diagram viewer #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
nad_read_metadata_svgparameters
to
integration/nad_interactive
July 19, 2024 15:39
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
flo-dup
force-pushed
the
nad_add_moving_flag
branch
from
cb17499
to
bfe11d8
Compare
flo-dup
approved these changes
Jul 19, 2024
7 tasks
flo-dup
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Make single-bus voltage level nodes movable in network area diagram (#59) * Move voltage level nodes with multiple buses in network area diagram (#65) * Fix node moving when zooming out after node selection in network area diagram (#71) * Move 3wt, dangling lines and voltage levels with unknown buses in nad viewer (#66) * Move nodes of uncomplete networks in network area diagram SVG (#68) * Update metadata and add callback for node moving in network area diagram (#73) * Move edge names when moving edges in network area diagram (#77) * Read SVG parameters from metadata in network area diagram (#79) * Add flag for enabling node moving (#80) * Add a transparent fill to unknown buses and three windings transformers in network area diagram (#81) Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
feature
What is the current behavior?
In the network area diagram viewer the functionality for moving the nodes is always enabled
What is the new behavior (if this is a feature change)?
A flag allows, when instantiating the viewer, to enable or disable the functionality for moving the nodes
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
the constructor of the NetworkAreaDiagramViewer has a new additional boolean flag parameter.
Examples are provided in the demo/src/diagram-viewers/add-diagrams.js file