Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement __new__ to avoid needless copies #137

Closed
nbraud opened this issue Mar 29, 2019 · 0 comments
Closed

Implement __new__ to avoid needless copies #137

nbraud opened this issue Mar 29, 2019 · 0 comments

Comments

@nbraud
Copy link
Collaborator

nbraud commented Mar 29, 2019

See discussion in #132
@AstraLuma AstraLuma mentioned this issue Apr 4, 2019
Merged
bors bot added a commit that referenced this issue Apr 6, 2019
@bors @AstraLuma @nbraud
Merge #142
f5c63ae 
142: Move to a non-copying constructor r=nbraud a=astronouth7303

Also remove `.convert()`.

Closes #137 

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
@bors bors bot closed this as completed in #142 Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nbraud