Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to a non-copying constructor #142

Merged
merged 5 commits into from
Apr 6, 2019
Merged

Move to a non-copying constructor #142

merged 5 commits into from
Apr 6, 2019

Conversation

AstraLuma
Copy link
Member

@AstraLuma AstraLuma commented Apr 4, 2019 •
edited
Loading

Also remove .convert().

Closes #137

@AstraLuma AstraLuma mentioned this pull request Apr 5, 2019
Merged
nbraud
nbraud requested changes Apr 6, 2019
View reviewed changes
Copy link
Collaborator

@nbraud nbraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggested changes; other than that, LGTM.

ppb_vector/vector2.py Outdated Show resolved Hide resolved
ppb_vector/vector2.py Outdated Show resolved Hide resolved
nbraud and others added 2 commits April 6, 2019 11:53
@nbraud @AstraLuma
vector2.py: Minor cleanup
6f3bacf 
Co-Authored-By: astronouth7303 <jamie@ivyleav.es>
@AstraLuma
vector2.py: s/other[xy]/other_[xy]/
5e0f4a4
@AstraLuma AstraLuma requested a review from nbraud April 6, 2019 15:56
@nbraud
Copy link
Collaborator

nbraud commented Apr 6, 2019

bors r+

bors bot added a commit that referenced this pull request Apr 6, 2019
@bors @AstraLuma @nbraud
Merge #142
f5c63ae 
142: Move to a non-copying constructor r=nbraud a=astronouth7303

Also remove `.convert()`.

Closes #137 

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
@bors
Copy link
Contributor

bors bot commented Apr 6, 2019

Build succeeded

  • docs
  • FreeBSD PYTHON:3.6
  • FreeBSD PYTHON:3.7
  • lint
  • Linux container:python:3.6-slim
  • Linux container:python:3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • Windows container:python:3.6-windowsservercore-1809
  • Windows container:python:3.7-windowsservercore-1809

@bors bors bot merged commit 5e0f4a4 into master Apr 6, 2019
@nbraud nbraud deleted the noncopy-ctor branch April 6, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbraud nbraud nbraud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AstraLuma @nbraud