Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make container-inner-max-width configurable #1254

Open
noraj opened this issue Dec 18, 2023 · 2 comments
Open

make container-inner-max-width configurable #1254

noraj opened this issue Dec 18, 2023 · 2 comments
Labels
feature:core Feature request that affects layout, styles, scripts, etc. wontfix Something that will not be done or fixed.

Comments

@noraj
Copy link
Contributor

noraj commented Dec 18, 2023

Is your feature request related to a problem? Please describe.

Why? On large screen (eg Full HD, 4k) or with large ratio (18:9, 21:9) etc. the container feels very tiny and there is too much space on the borders. Especially on pages where you disabled widgets and have only one column.
So making the max width configurable allows the site to behave better on large screens.

Describe the solution you'd like

Allow max_width to be configurable.

container:
    max_width: 1500px

cf. a PR for another theme https://github.com/ppoffice/hexo-theme-hueman/pull/280/files

as is applies not only to the content container but also to the navbar, it would probably require to have a max_width option for the navbar too.

Describe alternatives you've considered

None.

Additional context

Default fixed max-width (960px):

image

max-width of 1500px:

image

max-width: 100%

image

Instead of applying max-width and width values to .container, apply a size of 960px to .navbar-container and 1500px on a newly created class .content-container.

image

@ppoffice
Copy link
Owner

@ppoffice ppoffice added feature:core Feature request that affects layout, styles, scripts, etc. wontfix Something that will not be done or fixed. labels Dec 21, 2023
@noraj
Copy link
Contributor Author

noraj commented Dec 21, 2023

One can always write some custom modification but then you have to locally insclude the theme in your repository or maintain a custom fork. That's the whole point of having a config option so I can just keep the npm package and a config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:core Feature request that affects layout, styles, scripts, etc. wontfix Something that will not be done or fixed.
Projects
None yet
Development

No branches or pull requests

2 participants