Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SQLite dependency with newer .net standard compatible one #1045

Closed
wants to merge 5 commits into from

Conversation

Tom94
Copy link
Collaborator

@Tom94 Tom94 commented Sep 14, 2017

Re-submission of the pull request.

We need to ensure

  • works with 32 and 64 bit
  • works on linux and macos (at least test one of these)
  • works with old and fresh databases

@smoogipoo
Copy link
Contributor

Just gonna add something here:

1.5.xxx beta versions are used because they're the only ones that contain the migration fixes allowing us to remove the explicit MigrateTable calls present in the osu! database.

Further information can be found in this issue thread praeclarum/sqlite-net#461

@UselessToucan
Copy link
Contributor

@peppy Do you have any interest in using EF Core instead of SQLite.Net? I looked at the DB related code and it does not look like a huge problem.

@peppy
Copy link
Sponsor Member

peppy commented Sep 27, 2017

I'm open to other options, sure. If you're willing to give it a shot I see no harm in trying.

Would be interested to see if we still have Foreign Key support as we do with the SQLite.extensions package (along with cascade insert/delete/etc)

@Tom94
Copy link
Collaborator Author

Tom94 commented Oct 10, 2017

Could somebody post a comment here specifying why the PR is currently blocked? I forgot the reason (likely has to do with migration requiring a beta version of sqlite-net-pcl), and I think it would be good just for having a record.

@peppy
Copy link
Sponsor Member

peppy commented Oct 10, 2017

See my last comment in #1043. There's a low-level exception being thrown during disposal which seems to be affecting more people than just us.

There's no activity on the library itself, so it may be up to us to track down and fix this (at which point it may be worthwhile considering other libraries such as the EF version).

@UselessToucan
Copy link
Contributor

I will submit pull request with EF Core usage in 2-4 hours. I need some time for resolving merge conflicts and maybe for some refactoring.

@peppy
Copy link
Sponsor Member

peppy commented Oct 15, 2017

Closing in favour of #1085.

@peppy peppy closed this Oct 15, 2017
@Tom94 Tom94 deleted the net-standard-sqlite branch November 14, 2019 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants