New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace SQLite dependency with newer .net standard compatible one #1045
Conversation
Just gonna add something here: 1.5.xxx beta versions are used because they're the only ones that contain the migration fixes allowing us to remove the explicit Further information can be found in this issue thread praeclarum/sqlite-net#461 |
@peppy Do you have any interest in using EF Core instead of SQLite.Net? I looked at the DB related code and it does not look like a huge problem. |
I'm open to other options, sure. If you're willing to give it a shot I see no harm in trying. Would be interested to see if we still have Foreign Key support as we do with the SQLite.extensions package (along with cascade insert/delete/etc) |
Could somebody post a comment here specifying why the PR is currently blocked? I forgot the reason (likely has to do with migration requiring a beta version of sqlite-net-pcl), and I think it would be good just for having a record. |
See my last comment in #1043. There's a low-level exception being thrown during disposal which seems to be affecting more people than just us. There's no activity on the library itself, so it may be up to us to track down and fix this (at which point it may be worthwhile considering other libraries such as the EF version). |
I will submit pull request with EF Core usage in 2-4 hours. I need some time for resolving merge conflicts and maybe for some refactoring. |
Closing in favour of #1085. |
Re-submission of the pull request.
We need to ensure