Add two new update methods for AudioComponents to use #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
requested changes
Oct 25, 2017
| protected virtual void UpdateComponent() | ||
| { | ||
|
|
||
| } |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
smoogipoo
requested changes
Oct 25, 2017
| @@ -43,10 +43,10 @@ protected override void Dispose(bool disposing) | |||
| base.Dispose(disposing); | |||
| } | |||
|
|
|||
| public override void Update() | |||
| protected override void UpdateState() | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
smoogipoo
reviewed
Oct 25, 2017
| @@ -119,7 +119,7 @@ public override void Update() | |||
| currentAmplitudes.FrequencyAmplitudes = new float[256]; | |||
| } | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
requested changes
Oct 25, 2017
There was a problem hiding this comment.
As it stands now I see 2 problems with this PR:
- Calling
UpdateStatetwice does not fully address race conditions. It merely reduces the latency until cached values are updated and thereby makes data races less likely to occur. I would prefer a more fundamental solution to this problem. - Setting
isPlayingtofalsefrom the update thread may cause unpredictable behavior in audio-thread code which depends on the current state ofisPlaying. Essentially one type of data race is replaced by another.
Also changes order of execution to update the state *after* all queued actions are completed.
peppy
force-pushed
the
safe-audio-component-updates
branch
from
2d84a1c
to
4d6b330
Compare
Tom94
reviewed
Oct 27, 2017
| @@ -21,9 +21,17 @@ public class AudioComponent : IDisposable, IUpdateable | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Run each loop of the audio thread after queued actions to allow components to update anything they need to. | |||
| /// If we require | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
previously approved these changes
Oct 27, 2017
Tom94
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows state updates to be performed a second time post queued actions. Until now, if a queued action was to change a state which only got revalidated in a component's Update, it would be stale for a single frame.
This caused all end of race conditions, such as ppy/osu#1369