General fixes #205

peppy · 2016-10-21T07:19:58Z

No description provided.

…arios.

osu.Framework/Platform/BasicGameHost.cs

@@ -408,14 +406,13 @@ public override Vector2 Size
        {
            set
            {
-                InputScheduler.Add(delegate
+                UpdateScheduler.Add(delegate


osu.Framework.Desktop.Tests/Platform/HeadlessGameHostTest.cs

-                Assert.Pass();
+
+                Assert.IsTrue(waitAction.BeginInvoke(null, null).AsyncWaitHandle.WaitOne(1000),
+                    @"Message was not received in a timely fashion");


osu.Framework.Desktop/Platform/DesktopStorage.cs

-        protected abstract string BasePath { get; }
-
+
+        protected virtual string BasePath => @"./"; //use current directory by default


ddevault

.

ddevault · 2016-10-21T15:35:29Z

Per discussion on IRC I'll address my concerns with a seperate PR.

peppy force-pushed the general-fixes branch 4 times, most recently from 1bf0a77 to 62cd2a8 Compare October 21, 2016 09:22

peppy added 10 commits October 21, 2016 19:16

Return a more specific DesktopGameHost.

ab2ee0c

Bind IPC in the constructor so we don't need to call Load.

ec03a74

Fix timeout logic in HeadlessGameHost IPC test.

c35003e

Simplify delayed load logic for DesktopGameHost.

c143ced

Make DesktopStorage non-abstract so it can be used in very basic scen…

81048bf

…arios.

Don't create empty files when all we've asked for is to read a file.

0adc976

We should assume we're the primary instance until told otherwise.

11d1340

Add some new helper methods to the storage stack.

f30ff8c

Fix incorrect xmldoc.

724779b

Fix GameHost size setting regression.

e529585

peppy force-pushed the general-fixes branch from 62cd2a8 to e529585 Compare October 21, 2016 10:17

Tom94 reviewed Oct 21, 2016

View reviewed changes

osu.Framework/Platform/BasicGameHost.cs

@@ -408,14 +406,13 @@ public override Vector2 Size

{

set

{

InputScheduler.Add(delegate

UpdateScheduler.Add(delegate

This comment was marked as off-topic.

Sign in to view

Add comment about crappy logic.

90a5e4c

ddevault reviewed Oct 21, 2016

View reviewed changes

ddevault suggested changes Oct 21, 2016

View reviewed changes

ddevault approved these changes Oct 21, 2016

View reviewed changes

peppy merged commit 1ea56df into ppy:master Oct 21, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

General fixes #205

General fixes #205

peppy commented Oct 21, 2016

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

ddevault left a comment

ddevault commented Oct 21, 2016

		protected abstract string BasePath { get; }


		protected virtual string BasePath => @"./"; //use current directory by default

General fixes #205

General fixes #205

Conversation

peppy commented Oct 21, 2016

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

ddevault left a comment

Choose a reason for hiding this comment

ddevault commented Oct 21, 2016