Fix audio mixers potentially not showing in AudioMixer visualiser
#4875
Conversation
These would potentially never be fired due to the fact the work that is going to fire them is run on the audio thread, before the binding may have completed.
|
Regression tests could be added on the aforementioned test scene if required for this one. |
| /// <summary> | ||
| /// The handle for this mixer. | ||
| /// </summary> | ||
| public int Handle { get; protected set; } |
There was a problem hiding this comment.
This one is a little unfortunate because I think the audio subsystem was designed to look mostly agnostic from BASS but this handle is an implementation detail of BASS. On the other side it's kinda neither here nor there as MixerDisplay unceremoniously calls BassMix.MixerGetChannels() anyway...
I dunno, could be wrapped up a little nicer (eg. by exposing an abstract method returning channel levels here) but I'm not going to go and argue about it or anything.
There was a problem hiding this comment.
Yeah considering how dependent on bass everything around this is I didn't feel it was worth the time abstracting out.
There was a problem hiding this comment.
This class is supposed to be bass-agnostic. Is there a reason you couldn't (mixer as BassAudioMixer) instead?
There was a problem hiding this comment.
Can but felt pretty pointless (the whole visualiser depends on this).
There was a problem hiding this comment.
The visualiser isn't the only class using AudioMixer.
| /// <summary> | ||
| /// The handle for this mixer. | ||
| /// </summary> | ||
| public int Handle { get; protected set; } |
There was a problem hiding this comment.
This class is supposed to be bass-agnostic. Is there a reason you couldn't (mixer as BassAudioMixer) instead?
The underlying events would potentially be fired too early and never reach the hooking methods due to the fact the invocation call site is run on the audio thread, before the binding may have completed.
Also done some restructuring for a future PR which allows showing an identifying string on the visualiser.
Can be tested via the existing
TestSceneAudioMixerVisualiserwhile running in multi-thread mode (previously the new mixers would usually not display).