Show audio mixer identifier strings on the visualiser #4876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale is that it can no longer work without being in the audio hierarchy. A `TrackStore` should be used instead.
It doesn't support adjustments and is not in the expected location in the hierarchy. This only leads to confusion.
Remove broken `Handle` events These would potentially never be fired due to the fact the work that is going to fire them is run on the audio thread, before the binding may have completed.
Also pulls from `DrawableAudioMixer.Name`.
bdach
reviewed
Nov 9, 2021
| @@ -18,7 +18,7 @@ public class DrawableAudioMixer : AudioContainer, IAudioMixer | |||
| [BackgroundDependencyLoader] | |||
| private void load(AudioManager audio) | |||
| { | |||
| mixer = audio.CreateAudioMixer(); | |||
| mixer = audio.CreateAudioMixer(Name); | |||
There was a problem hiding this comment.
Unfortunate that this is timing dependent (will only work if set prior to load). Not sure if it's worth spending the time to add support for arbitrary-timed changes. If we had initialisers then we could use that to make sure it's not an issue ever but alas...
There was a problem hiding this comment.
Not sure it matters too much. Very rare you'd be setting the name of a drawable at any point after construction.
bdach
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found it hard to track what's what. This helps somewhat.
AudioMixervisualiser #4875 to avoid merge conflicts.