Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop logging non-error output from OpenTabletDriver #6006

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Sep 26, 2023

See ppy/osu#24915. Maybe wait for a response before going ahead with this, but it doesn't seem worthwhile to log non-errors to the user.

See ppy/osu#24915. Maybe wait for a
response before going ahead with this, but it doesn't seem worthwhile to
log non-errors to the user.
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like @X9VoiD is on board with this change according to the discussion thread, so I'll go ahead and merge.

@smoogipoo smoogipoo merged commit 2422682 into ppy:master Sep 26, 2023
17 of 21 checks passed
@peppy peppy deleted the dont-log-non-error branch September 27, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants