Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Padding property in GridContainer #6145

Merged
merged 3 commits into from Jan 29, 2024
Merged

Implement Padding property in GridContainer #6145

merged 3 commits into from Jan 29, 2024

Conversation

EVAST9919
Copy link
Contributor

Helps in container nesting reduction.
(34b3fda includes some examples, is osu there are quite a few as well)

@EVAST9919 EVAST9919 mentioned this pull request Jan 20, 2024
Closed
@Joehuu Joehuu self-requested a review January 24, 2024 01:06
Joehuu
Joehuu approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@Joehuu Joehuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem fine (easier to read with hide whitespace).

@smoogipoo smoogipoo merged commit fe32cab into ppy:master Jan 29, 2024
13 checks passed
@EVAST9919 EVAST9919 deleted the grid-padding branch January 29, 2024 13:07
@EVAST9919 EVAST9919 mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

@Joehuu Joehuu Joehuu approved these changes

Assignees
No one assigned
Labels
area:drawable size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EVAST9919 @smoogipoo @Joehuu @peppy