Make shader setter in SpriteText protected

[EVAST9919]

Needed for my personal project.

[peppy]

Hmm, usually we'd made a CreateTextureShader method and expose that instead. I'm not against just exposing as protected because it's very hard to misuse (you'd have to set it in the ctor to have it overwritten by framework).

At very least, xmldoc mentioning this is automatically set but can be overwritten post-load?

Will wait for another opinion though.

[peppy]

as commented

[bdach]

Hmm, usually we'd made a CreateTextureShader method and expose that instead.

Sprite doesn't do this and it already has consumers of its protected setter:

osu-framework/osu.Framework/Graphics/Sprites/Sprite.cs

Line 33 in 980b4cd

public IShader TextureShader { get; protected set; }

As to whether it should, I guess I have no big feelings about that, but arbitrary setter allows for doing more (aside from the pitfall of setting it in ctor).

you'd have to set it in the ctor to have it overwritten by framework

At very least, xmldoc mentioning this is automatically set but can be overwritten post-load?

xmldoc can be added for sure. Though attempting to procure an IShader instance in a ctor would be mighty annoying I'd imagine so you could argue the API inertia here should already prevent that pitfall. But I agree that mentioning it (in both places maybe even) would not hurt.