Ignore editlist when decoding mp4/mov videos #6311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ppy/osu#13696. The editlist would cause storyboard videos to not play back the same way stable (and most other video players) plays them back.
peppy
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ppy/osu#13696.
The editlist would cause storyboard videos to not play back the same way stable (and most other video players) plays them back.
It took me about 2 hours to figure out how to call this, and only managed to do it thanks to github-wide search returning something that looked like what I wanted after a lot of time wasted staring at ffmpeg docs, and ffmpeg source, and debugging ffplay to figure out how the hell it was passing everything and not being able to tell. C is a hell of a drug.