Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop marking scores as ranked = 0 for pp only purposes #227

Merged
merged 1 commit into from Feb 28, 2024

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Feb 27, 2024

We use this flag for cases where scores should not be considered for PP or leaderboards now. Cases where PP is not required simply leaves it as null.

@smoogipoo smoogipoo merged commit c89892d into ppy:master Feb 28, 2024
3 checks passed
@bdach
Copy link
Collaborator

bdach commented Feb 28, 2024

Cases where PP is not required simply leaves it as null.

I assume this is going to regress the pp display fix made at ppy/osu-web#10918 / ppy/osu#27053 for scores set e.g. on unranked mods? cc @ppy/team-web

I'm not sure how to fix either because both "pp pending calculation" and "pp is just not given for this score" are indistinguishable. Unless you check the process history entry maybe.

@peppy
Copy link
Sponsor Member Author

peppy commented Feb 29, 2024

Yeah, good call there. We'll either need to have local logic to check the conditions for whether a score should award PP, or come up with another value to represent what we were using null for..

I guess using the process_history could work, although I'm not confident we'll be keeping that table around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants