Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scores set with mods which don't support pp show as "This score is still being calculated" #10911

Closed
peppy opened this issue Jan 30, 2024 · 1 comment · Fixed by #10918 or #11151
Closed

Scores set with mods which don't support pp show as "This score is still being calculated" #10911

peppy opened this issue Jan 30, 2024 · 1 comment · Fixed by #10918 or #11151
Assignees
@bdach
Labels
area:user-profile priority:0 Showstopper. Critical to the next release.

Comments

@peppy
Copy link
Sponsor Member

peppy commented Jan 30, 2024 •
edited

Example (ignore that this actually has no mods):

Safari 2024-01-30 at 07 06 44

They should say something more like "pp was not awarded for this score due to invalid beatmap or mods".
@peppy peppy added area:user-profile priority:0 Showstopper. Critical to the next release. labels Jan 30, 2024
@notbakaneko notbakaneko mentioned this issue Jan 30, 2024
Merged
@bdach
Copy link
Contributor

bdach commented Apr 8, 2024

This has regressed after ppy/osu-queue-score-statistics#227.

@bdach bdach reopened this Apr 8, 2024
@bdach bdach self-assigned this Apr 9, 2024
@bdach bdach mentioned this issue Apr 9, 2024
Merged
notbakaneko pushed a commit that referenced this issue Apr 22, 2024
@bdach
Fix scores set with unranked mods showing as processing indefinitely …
ade9f0a 
…(again)

Closes #10911 once more.

The actual fix is the inclusion of and check for existence of the
`score_process_history` row as it is the most reliable indicator of
processing having concluded.

This also includes a drive-by inclusion of a `preserve === false` check
that won't really do anything right now, but will if / once
ppy/osu-queue-score-statistics#141 is
resolved.

The goal here is to only show pp values on scores that contribute to the
user's total. The query determining can be found here:

	https://github.com/ppy/osu-queue-score-statistics/blob/f65dec335a914ee171d69981719d6ccb1d3f0ebe/osu.Server.Queues.ScoreStatisticsProcessor/Processors/UserTotalPerformanceProcessor.cs#L66-L76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdach bdach

Labels
area:user-profile priority:0 Showstopper. Critical to the next release.
Projects
osu!lazer "pp" release issue tracker
Archived in project
Milestone
No milestone
2 participants
@peppy @bdach