Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wiki] Disable the ability to use locale to access non-standard files #2602

Closed
TPGPL opened this issue Mar 1, 2018 · 1 comment · Fixed by #2631
Closed

[wiki] Disable the ability to use locale to access non-standard files #2602

TPGPL opened this issue Mar 1, 2018 · 1 comment · Fixed by #2631
Assignees
Milestone

Comments

@TPGPL
Copy link
Contributor

TPGPL commented Mar 1, 2018

Currently you can use ?locale=README to access the README.md file, which shouldn't be possible. The solution to this problem might be parsing only the 2-letter file names.

Example: https://osu.ppy.sh/help/wiki/Tournaments?locale=README

https://github.com/ppy/osu-wiki/tree/master/wiki/Tournaments

also for some reason setting locale to TEMPLATE for Tournaments breaks the site completely maybe because of curly brackets ❓

@kj415j45
Copy link
Sponsor Contributor

kj415j45 commented Mar 1, 2018

don't forget there's pt-br

@peppy peppy added this to the March 2018 milestone Mar 2, 2018
@nanaya nanaya self-assigned this Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants