Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler forum authorization #4317

Open
cl8n opened this issue Apr 9, 2019 · 5 comments
Open

Simpler forum authorization #4317

cl8n opened this issue Apr 9, 2019 · 5 comments

Comments

@cl8n
Copy link
Member

cl8n commented Apr 9, 2019

I wanted to look into replacing phpbb forum auth soon (as mentioned by lots of comments saying "this is temporary" etc), but I'm not sure which features are needed

a comment says that user-specific ACLs are no longer used but I don't have info beyond that. I think all i'd need is a list of the permission types still in use and whether or not "roles" are necessary anymore

@peppy
Copy link
Sponsor Member

peppy commented Apr 9, 2019

One prerequisite for this is to turn off the old forums, i believe. And I think we are actually ready to do this.

As for roles, we still do have forum-group specific roles (ie support team with help forum access) so we'd likely need to consider that. A table with group_id, forum_id and then a number of bool columns for specific permissions may be enough

@peppy
Copy link
Sponsor Member

peppy commented Apr 9, 2019

cc/ @nanaya in case he can think of any edge cases or special requirements i may have missed.

@cl8n
Copy link
Member Author

cl8n commented Apr 9, 2019

by roles I meant AuthRoles which seem to give global permissions for usergroups. to my knowledge all of this is already taken care of by OsuAuthorize so I think we can get rid of it?

@nanaya
Copy link
Collaborator

nanaya commented Apr 9, 2019

Some checks in OsuAuthorize still use old forum acl.

@peppy
Copy link
Sponsor Member

peppy commented Sep 18, 2019

This can be reconsidered now, if there is interest. Removing ACL completely would be a huge step forward.

@peppy peppy removed this from the Candidate Issues milestone Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants