-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add badge for moderators of forums #6232
Conversation
What kind of scenario is it important to know this? The idea of keeping moderators unidentifiable is something we have always stood behind where possible. |
I've gotten the (very) occasional PMs where someone is confused about not being able to make new threads on the Loved forum, it seems like the confusion comes from me looking like a normal user and I make all the threads there. that was the immediate reason I just made this change, but in general it seems like the other forum moderators are pretty identifiable--- they've all got badges of some kind and you can look at their group listings I don't have a very strong opinion about this but I thought it'd be making things more consistent. |
Lets go with this 👍 . |
On further internal discussion, it's looking like all forum moderators are already in a group which is exposed, apart from the "loved" forum group. Is there another case you are aware of @cl8n? |
@@ -19,6 +19,13 @@ | |||
} | |||
|
|||
$user = $post->userNormalized(); | |||
$group = isset($topic) && $user->isModeratorForForum($topic->forum) | |||
? (object)[ | |||
'colour' => 'hsl(200, 60%, 50%)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where's this colour coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
colour: 'hsl(200, 60%, 50%)', |
was just to get it working, idk if that makes sense for design
if there haven't been any changes since |
this was waiting for some feedback from @peppy, I think? |
@peppy 🏓 |
I honestly don't know if this is necessary or just added complexity. Tempted to lean in the direction of #2 based on how few people this affects. |
I think the consensus here is that this is probably not required, so going to close for the time being. We can re-visit if this applies to more user groups in the future. |
you can't tell who moderators of forums are unless they're in one of the global mod groups, so this adds a fake-group badge to show that. works and looks similar to "Mapper" for beatmap discussions