Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add badge for moderators of forums #6232

Closed
wants to merge 2 commits into from
Closed

Conversation

cl8n
Copy link
Member

@cl8n cl8n commented Jun 25, 2020

you can't tell who moderators of forums are unless they're in one of the global mod groups, so this adds a fake-group badge to show that. works and looks similar to "Mapper" for beatmap discussions

@peppy
Copy link
Sponsor Member

peppy commented Jun 25, 2020

What kind of scenario is it important to know this? The idea of keeping moderators unidentifiable is something we have always stood behind where possible.

@cl8n
Copy link
Member Author

cl8n commented Jun 25, 2020

I've gotten the (very) occasional PMs where someone is confused about not being able to make new threads on the Loved forum, it seems like the confusion comes from me looking like a normal user and I make all the threads there. that was the immediate reason I just made this change, but in general it seems like the other forum moderators are pretty identifiable--- they've all got badges of some kind and you can look at their group listings

I don't have a very strong opinion about this but I thought it'd be making things more consistent.

@peppy
Copy link
Sponsor Member

peppy commented Jul 14, 2020

Lets go with this 👍 .

@peppy
Copy link
Sponsor Member

peppy commented Jul 14, 2020

On further internal discussion, it's looking like all forum moderators are already in a group which is exposed, apart from the "loved" forum group. Is there another case you are aware of @cl8n?

@@ -19,6 +19,13 @@
}

$user = $post->userNormalized();
$group = isset($topic) && $user->isModeratorForForum($topic->forum)
? (object)[
'colour' => 'hsl(200, 60%, 50%)',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's this colour coming from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


was just to get it working, idk if that makes sense for design

resources/views/forum/topics/_post.blade.php Show resolved Hide resolved
@cl8n
Copy link
Member Author

cl8n commented Jul 16, 2020

if there haven't been any changes since moderator_groups was added to forums, then yeah loved is the only one. maybe this display would make more sense after #4317 (comment), where you might have certain users moderating forums without belonging to a group

@notbakaneko notbakaneko marked this pull request as draft August 6, 2020 04:08
@notbakaneko
Copy link
Collaborator

this was waiting for some feedback from @peppy, I think?

@cl8n
Copy link
Member Author

cl8n commented Oct 3, 2020

@peppy 🏓

@peppy
Copy link
Sponsor Member

peppy commented Oct 27, 2020

I honestly don't know if this is necessary or just added complexity. Tempted to lean in the direction of #2 based on how few people this affects.

@peppy
Copy link
Sponsor Member

peppy commented Nov 5, 2020

I think the consensus here is that this is probably not required, so going to close for the time being. We can re-visit if this applies to more user groups in the future.

@peppy peppy closed this Nov 5, 2020
@cl8n cl8n deleted the forum-mod-badge branch April 28, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants