Read & store score total without mods on submission #11211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
are we going ahead with this? seems working apart of the interface in |
Correct me if I'm wrong but that looks like a frontend-facing interface? I wasn't really intending on exposing this to the frontend at all, it's basically only intended for internal / maintenance usage for when we do need to rebalance mod multipliers for the time being. |
|
yeah but the it kind of documents what attributes the json has |
bdach
added a commit
to bdach/osu-web
that referenced
this pull request
May 23, 2024
|
Does 1ded710 work for that? Do I need to be doing other than just that? |
nanaya
requested changes
May 23, 2024
| @@ -48,6 +48,7 @@ type SoloScoreJsonDefaultAttributes = { | |||
| started_at: string | null; | |||
| statistics: Partial<Record<SoloScoreStatisticsAttribute, number>>; | |||
| total_score: number; | |||
| total_score_without_mods?: boolean; | |||
There was a problem hiding this comment.
yes but why is it a boolean 🤔
There was a problem hiding this comment.
whoooooooooooooooooops
bdach
force-pushed
the
total-score-without-mods
branch
from
1ded710
to
c866744
Compare
nanaya
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being sent from the client after ppy/osu#27912. There's no actual release with that pull out yet, so if you wanna test full-stack, test with latest game
master.The intended place of storage is the
datajson. @peppy initially wanted to do a new column for this, but unfortunately due to the fact that columns cannot be added online toROW_FORMAT=COMPRESSEDtables, this is not very easy to do on a table with several billion records inside. Thus in the json it goes. It's not guaranteed json will be much better either due to the unpredictable behaviour of json compression, but it seems to be the best way forward.The param is nullable / allowed-missing for now. It will probably cease to be after submission is disabled for clients that don't send it, and all rows that have it missing are back-populated.
The end goal in sight here is to be able to do perpetual mod multiplier rebalances without precision loss, e.g. ppy/osu#27685. In the future this could also prove useful for something like custom mod multiplier support for tournaments.