Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display nominations in order of nomination #2346

Merged
merged 2 commits into from
Feb 9, 2018

Conversation

nekodex
Copy link
Collaborator

@nekodex nekodex commented Feb 9, 2018

fixes #2084

@@ -233,7 +233,7 @@ class BeatmapDiscussions.Nominations extends React.PureComponent
className: "#{bn}__note #{bn}__note--nominators"
dangerouslySetInnerHTML:
__html: osu.trans 'beatmaps.nominations.nominated_by',
users: nominators.map (user) ->
users: nominators.reverse().map (user) ->

This comment was marked as off-topic.

@nanaya nanaya merged commit a1606d2 into ppy:master Feb 9, 2018
@nanaya
Copy link
Collaborator

nanaya commented Feb 9, 2018

also more like "display nominators"?

@nekodex nekodex deleted the nomination-order branch March 30, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nominators are listed in wrong order
2 participants