New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override trans to ignore empty strings #3194

Merged
merged 2 commits into from May 14, 2018

Conversation

2 participants
@nanaya
Collaborator

nanaya commented May 14, 2018

To work with crowdin. Fix Lang.choice and do minor cleanup while at it.

  • only use trans() and trans_choice() for php
  • only use osu.trans() and osu.transChoice() for javascript
    • add osu.presence helper to allow chaining
    • don't set fallback locale
    • as it turned out the library hasn't been updated with plural rule bug fix

nanaya added some commits May 14, 2018

Override trans to ignore empty strings
- only use trans() and trans_choice() for php
- only use osu.trans() and osu.transChoice() for javascript
  - add osu.presence helper to allow chaining
  - don't set fallback locale
  - as it turned out the library hasn't been updated with plural rule bug fix
@peppy

peppy approved these changes May 14, 2018

@peppy peppy added this to the May 2018 milestone May 14, 2018

@peppy peppy merged commit ba18b1d into ppy:master May 14, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nanaya nanaya deleted the nanaya:ignore_empty_string_trans branch May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment