Return json on error for a json request #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajax only covers requests with `X-Requested-With=XMLHttpRequest`. And change expectsJson to wantsJson. The former also includes ajax requests.
|
Actually, why doesn't the html version of |
nekodex
reviewed
May 30, 2018
app/Exceptions/Handler.php
Outdated
| @@ -120,7 +120,7 @@ public function render($request, Exception $e) | |||
|
|
|||
| protected function unauthenticated($request, AuthenticationException $exception) | |||
| { | |||
| if ($request->expectsJson()) { | |||
| if ($request->wantsJson()) { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I vaguely remember browsers showing native auth dialog if returning 401. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ajaxonly covers requests withX-Requested-With=XMLHttpRequest.And change
expectsJsontowantsJson. The former also includesajaxrequests.