-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ranking criteria] Add metadata draft #11563
Open
Okorin
wants to merge
12
commits into
ppy:master
Choose a base branch
from
Okorin:metadata-draft
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needed to get this in as moving the article out of the general rc means i need to change general rc to reorganize its structure. hope this is fine
adds the draft from https://osu.ppy.sh/community/forums/topics/1894663?n=1
Someone else has edited same files as you did. Please check their changes in case they conflict with yours: |
NoffyNoffeh
reviewed
Jun 13, 2024
2 tasks
NoffyNoffeh
reviewed
Jul 29, 2024
This was referenced Aug 2, 2024
This was referenced Aug 13, 2024
Co-authored-by: Dorothy <33286824+NoffyNoffeh@users.noreply.github.com>
@peppy You asked me to ping you on the conversation to check this out |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
since the changes aren't intended to change ANY behaviour and are instead about formatting, I skipped making a separate discussion thread for moving this around
The comment about
(Slowed Down Ver.)
is not included in this draft for now for the following reason: These songs aren't common enough to warrant their own mention and they'd be covered by "make a sensible marker" via the#### Ver.
guideline introduced.Some american english may still be left and some phrasing may still include a bit simpler language. I personally think the simpler language is fine