Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve How you can help page #1989

Merged
merged 31 commits into from
Mar 21, 2019
Merged

Improve How you can help page #1989

merged 31 commits into from
Mar 21, 2019

Conversation

sr229
Copy link
Contributor

@sr229 sr229 commented Jan 22, 2019

Redone "How You Can Help" to be more in-line with current standards, and be formalized as a wiki article.

Fixes #1548

Hikari Kibo added 4 commits January 22, 2019 17:48
refactor: Improve How you can Help page
5315777 
Fixes #1548
docs: fix typo
c215331 
Signed-off-by: Hikari Kibo <enra@sayonika.moe>
docs: remove redundant projects
314c586 
Signed-off-by: Hikari Kibo <enra@sayonika.moe>
docs: fix typo
d46cbb4 
Signed-off-by: Hikari Kibo <enra@sayonika.moe>
@sr229
Copy link
Contributor Author

sr229 commented Feb 1, 2019

CC for RFC @MegaApplePi

@sr229
Copy link
Contributor Author

sr229 commented Feb 1, 2019

CC for RFC @FreezyLemon

FreezyLemon
FreezyLemon reviewed Feb 2, 2019
View reviewed changes
Copy link
Contributor

@FreezyLemon FreezyLemon left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a solid start overall.

That said, there are some grammatical mistakes and typos that should be fixed before merging (I didn't go over all of them for this review, but I can do that if you want me to).

wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
Hikari Kibo added 2 commits February 3, 2019 02:33
fix: apply suggestions
98902f0 
Signed-off-by: Hikari Kibo <enra@sayonika.moe>
fix: remove project citations
49b3a89 
Signed-off-by: Hikari Kibo <enra@sayonika.moe>
@TPGPL TPGPL added the update label Feb 3, 2019
@cl8n
Copy link
Member

cl8n commented Feb 8, 2019

this re-write has a strangely negative tone (I doubt it was intentional, but that's how it reads)...

  • "[...] as many newcomers think" assumes the reader has been misinformed previously
  • "It's not always sunshine in the osu! community, [...]" - there should be a good way to word this without explicitly stating that problems exist (that's not what this article is for)
  • "Stop complaining"

fix: redo wordings for Section 2 and 4
271ae93 
Signed-off-by: Hikari Kibo <enra@sayonika.moe>
@sr229
Copy link
Contributor Author

sr229 commented Feb 9, 2019

Revised some parts, sorry for the unintentional negative wording, I tried to make it "peppy" as possible

(no pun intended)

fix: Hotfix broken commmit
a0f7613 
there was a terrible write buffer error that caused a race condition so I had to commit this.
MegaApplePi
MegaApplePi reviewed Feb 22, 2019
View reviewed changes
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
MegaApplePi
MegaApplePi requested changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@MegaApplePi MegaApplePi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dang it GitHub, why did that Control+Enter submit the review

wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
Joehuu
Joehuu requested changes Feb 22, 2019
View reviewed changes
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
MegaApplePi
MegaApplePi requested changes Mar 2, 2019
View reviewed changes
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
MegaApplePi and others added 12 commits March 3, 2019 22:53
@MegaApplePi
apply suggestions
13fac9b 
Co-Authored-By: sr229 <enra@sayonika.moe>
@MegaApplePi
apply suggestions
3993ebf 
Co-Authored-By: sr229 <enra@sayonika.moe>
@MegaApplePi
apply suggestions
be4a866 
Co-Authored-By: sr229 <enra@sayonika.moe>
@MegaApplePi
apply suggestions
cf42d08 
Co-Authored-By: sr229 <enra@sayonika.moe>
@MegaApplePi
apply suggestions
bebc0e7 
Co-Authored-By: sr229 <enra@sayonika.moe>
@MegaApplePi
apply suggestions
f724c4e 
Co-Authored-By: sr229 <enra@sayonika.moe>
@MegaApplePi
apply suggestions
73ff64a 
Co-Authored-By: sr229 <enra@sayonika.moe>
@MegaApplePi
apply suggestions
fa01a6a 
Co-Authored-By: sr229 <enra@sayonika.moe>
@MegaApplePi
apply suggestions
78ae502 
Co-Authored-By: sr229 <enra@sayonika.moe>
@MegaApplePi
apply suggestions
483dc23 
Co-Authored-By: sr229 <enra@sayonika.moe>
@MegaApplePi
apply suggestions
280943a 
Co-Authored-By: sr229 <enra@sayonika.moe>
@MegaApplePi
apply suggestions
73ac71e 
Co-Authored-By: sr229 <enra@sayonika.moe>
MegaApplePi and others added 6 commits March 3, 2019 22:58
@MegaApplePi
apply suggestions
83a0871 
Co-Authored-By: sr229 <enra@sayonika.moe>
@MegaApplePi
apply suggestions
45e0963 
Co-Authored-By: sr229 <enra@sayonika.moe>
Apply suggestions from code review
f68f2a7 
Co-Authored-By: sr229 <enra@sayonika.moe>
@Joehuu
apply missed suggestion from batch
a5b5594 
Co-Authored-By: sr229 <enra@sayonika.moe>
Merge branch 'master' into GH-1548
eb7d65f
fix :rephrase Section 3
e11c0bb 
Signed-off-by: Hikari Kibo <enra@sayonika.moe>
@sr229
Copy link
Contributor Author

sr229 commented Mar 16, 2019

RFC again for merge ty

@MegaApplePi
Update wiki/How_You_Can_Help!/en.md
0499ece 
Co-Authored-By: sr229 <enra@sayonika.moe>
@cl8n
Copy link
Member

cl8n commented Mar 18, 2019

I'll review later this week

MegaApplePi
MegaApplePi previously approved these changes Mar 18, 2019
View reviewed changes
peppy
peppy reviewed Mar 19, 2019
View reviewed changes
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
peppy
peppy reviewed Mar 19, 2019
View reviewed changes
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
peppy
peppy requested changes Mar 19, 2019
View reviewed changes
Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned, good otherwise

@peppy
Apply suggestions from code review
0805eb8 
Co-Authored-By: sr229 <enra@sayonika.moe>
@sr229
Copy link
Contributor Author

sr229 commented Mar 19, 2019

Suggestion applied, RFC again for merge.

Joehuu
Joehuu requested changes Mar 19, 2019
View reviewed changes
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
wiki/How_You_Can_Help!/en.md Outdated Show resolved Hide resolved
Joehuu and others added 2 commits March 20, 2019 11:45
@Joehuu
Apply suggestions from code review
6fd3d20 
Co-Authored-By: sr229 <enra@sayonika.moe>
@Joehuu
fix: Update wiki/How_You_Can_Help!/en.md
6edfd06 
Co-Authored-By: sr229 <enra@sayonika.moe>
@peppy peppy merged commit f7cea51 into ppy:master Mar 21, 2019
@sr229 sr229 deleted the GH-1548 branch March 21, 2019 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FreezyLemon FreezyLemon FreezyLemon left review comments

@Joehuu Joehuu Joehuu requested changes

@peppy peppy peppy approved these changes

@MegaApplePi MegaApplePi MegaApplePi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sr229 @cl8n @peppy @FreezyLemon @MegaApplePi @Joehuu @TPGPL