Clean up name order RC #6079
Merged
Clean up name order RC #6079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ephemeralis
reviewed
Sep 8, 2021
Co-authored-by: David Sinclair <Ephemeralis@users.noreply.github.com>
|
This looks fine to me. I'll let it stew for a few days before approving in case anyone else wants to ogle at it. |
peppy
reviewed
Sep 9, 2021
Walavouchey
reviewed
Sep 9, 2021
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
peppy
reviewed
Sep 9, 2021
peppy
reviewed
Sep 9, 2021
|
As a heads up, generally you'd discuss an alternative in the review conversation before committing it. As seen here, your new change is no better, so it would be best to discuss and reach a consensus rather than just committing again and again. |
|
flowchart based on brief discussion with Noffy in
hopefully this clears any ambiguities when trying to review. |
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
peppy
reviewed
Sep 11, 2021
|
please exclude the id.md file, we still has a PR open on #6118 |
|
I'd rather keep it to inform others that it's not up to date: even if you and me are aware of it, others aren't |
|
Is this waiting on anything in particular? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change makes it so it would largely be handled the same way as song titles are already, making it more consistent to understand how to apply the rules across the board.
see thread:
https://osu.ppy.sh/community/forums/topics/1415070?n=1
Depends on #6149