Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection is lost when a HitObject is moved to another playfield when using pooling #11453

Closed
LumpBloom7 opened this issue Jan 10, 2021 · 1 comment · Fixed by #12783
Closed
Labels
area:editor priority:2 Moderately important. Relied on by some users or impeding the usability of the game

Comments

@LumpBloom7
Copy link
Contributor

LumpBloom7 commented Jan 10, 2021

Describe the bug:
When handling a movement within the selection handler, if the resulting position leads to the HitObject changing playfields, the HitObject is deselected, requiring users to reselect and repeat to move further.

Problem encountered in the sentakki ruleset, the lane in LanedHitObject is handled similarly to columns in ManiaHitObject.
https://github.com/LumpBloom7/sentakki/blob/Editor/osu.Game.Rulesets.Sentakki/Edit/SentakkiSelectionHandler.cs#L26-L50

A half-workaround that I did manage to find is to remove the HO from EditorBeatmap.SelectedHitObjects, then readding it after the lane has been changed. This ensures the SelectionBlueprint is shown, but still won't continue responding to the current drag event.

Screenshots or videos showing encountered issue:

2021-01-10.16-46-29.mp4

osu!lazer version:
2021.109.0

Logs:
N/A

@peppy
Copy link
Sponsor Member

peppy commented Jan 11, 2021

I guess we haven't encountered this yet because mania doesn't use pooling. I think this will likely be addressed along with the mania pooling implementation in the coming month or two.

@peppy peppy added this to the February 2021 milestone Jan 11, 2021
@peppy peppy added the priority:2 Moderately important. Relied on by some users or impeding the usability of the game label Mar 17, 2021
@peppy peppy removed this from the February 2021 milestone Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editor priority:2 Moderately important. Relied on by some users or impeding the usability of the game
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants