Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Sentakki Editor #75

Closed
wants to merge 44 commits into from
Closed

Implement Sentakki Editor #75

wants to merge 44 commits into from

Conversation

LumpBloom7
Copy link
Owner

No description provided.

Since the hitarea is detached from the note visuals, it makes selecting very odd.
Avoids an issue where notes can be selected before they first become visible
In the SSDQ, TopLeft may not actually be the top left, and the SelectionHandler doesn't safely handle such cases.

To resolve this, a function is used to make sure everything is correct before it goes down the chain.
Use the selection pieces' SSDQ as the selection quad

The HOLD selection is using a rotated SSDQ, so it has to be converted to an Rectanglef (which makes sure everything is the right way up). It is shrunk so that the quad size appears roughly the same to the other quads
Changes the Angle variable into a bindable, so that visual jank is avoided. Looking to change this in another PR.
@LumpBloom7
Copy link
Owner Author

Slides are able to have multiples paths, with different properties (duration, pattern, delay), while sharing the same tap. The current composer for slides assumes that slides are guaranteed to only have a single pattern.

I don't really know how I should go about supporting multiple patterns with the current UI. An option would be to make each slide a unique hitobject, and merge them in post-process, but the post-process applies in editor as well, and it makes it a bit harder to deal with.

I need to think of a better way to adjust the properties of nested hitobjects individually. Something like double-clicking the slide pattern to isolate the object and to adjust it as normal.

@LumpBloom7
Copy link
Owner Author

ppy/osu#10108

This addition would help tremendously, but it only works well for anything that isn't related to hitobject timing, since I'd would want to be able to adjust them as if they are a regular object (via the timeline or whatnot)

@LumpBloom7
Copy link
Owner Author

LumpBloom7 commented Jan 10, 2021

Looking into this issue: chelone-glabra#1

Based on a surface level glance, when the laned notes change lanes, another DHO takes the place of the original DHO due to pooling, instead of the DHO being shifted to the new lane. Each blueprint is associated with a DHO, so a blueprint will change when the lane change, causing the SelectedHitObject list to change.

osu-side issue: ppy/osu#11453

@LumpBloom7
Copy link
Owner Author

Closing in favor of #220

@LumpBloom7 LumpBloom7 closed this May 11, 2021
@LumpBloom7 LumpBloom7 deleted the Editor branch February 1, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant