Implement Sentakki editor #220
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One at a time for now
Still pretty fucked, and pending fix osu-side
Will need to make use of future additions to the editor osu-side to make this work better.
It could intrude on the user who is using the slide toolbox
Still recreates every frame for now
Since we provide lane info already in snapping, we don't actually need to figure that out in HandleMovement
Allows for better visual representation when adjusting time via snapping. Hold notes also keep their full length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the composer screen that will be used to compose Sentakki beatmaps. I've chosen to start over despite my previous attempt, as a lot of the code there is copied from osu!std, reducing my understanding and familiarity with the implementation.
osu doesn't really support custom ruleset editors at the moment(ppy/osu#12612), but we can still work on them in the meantime.
Most of the basic functionality have been implemented, however there are still certain things that needs to be worked on.
Current problems
SlideBodySelection is lost when a HitObject is moved to another playfield when using pooling ppy/osu#11453Current composition placement being cancelled by other HitObjects becoming alive in the editor ppy/osu#12630Repositioning of hit objects are blocked when more than one blueprint is selectedUnlike mania, the lanes of sentakki are circular... Maybe rotate all of them based on the drag origin.resolvedTouch notes should support simultaneous repositioning, but bounds checking is also not as simple as AABB. I'm currently thinking on a way to block movement based on distance to playfield centre.resolved (Thanks @Flutterish!)HitExplosions for TouchNotes remain, even though they are hidden for LanedNotes.