Add "Start cinema mod with Ctrl+Shift+Enter" #11047
Conversation
Based on "mod disabled" assert in TestCinemaViaCtrlShiftEnter test
|
This has been attempted once before in #9224, and as far as I can see, this implementation suffers from the exact same bug that prevented that one from being merged. |
|
I'm not even sure we want this. Cinema is such a rare use case that I feel it probably doesn't need its own dedicated (hidden) hotkey.. |
| if (Mods.Value.Any(m => m.GetType() == Ruleset.Value.CreateInstance().GetAutoplayMod()?.GetType())) return Ruleset.Value.CreateInstance().GetAutoplayMod(); | ||
| else if (Mods.Value.Any(m => m.GetType() == Ruleset.Value.CreateInstance().GetCinemaMod()?.GetType())) return Ruleset.Value.CreateInstance().GetCinemaMod(); |
There was a problem hiding this comment.
I don't agree with this being handled locally as done here. The higher-level logic of mod selection/deselection should be deselecting one when the other is selected, via IncompatibleMods or similar. (see #7155) Otherwise we're going to end up with local fixes every time an issue like this arises.
That was also another problem the previous attempt at this had.
| { | ||
| notifications?.Post(new SimpleNotification | ||
| { | ||
| Text = "The current ruleset doesn't have an autoplay mod avalaible!" | ||
| Text = "The current ruleset doesn't have an autoplay/cinema mod avalaible!" |
There was a problem hiding this comment.
this text should depend on the hotkey pressed, not be an either/or catch-all
Add hotkey to "cinema" mod as in osu!stable.
Closes #9221.