Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add low difficulty spacing checks #13606

Merged
merged 6 commits into from
Jun 22, 2021
Merged

Add low difficulty spacing checks #13606

merged 6 commits into from
Jun 22, 2021

Conversation

Naxesss
Copy link
Contributor

@Naxesss Naxesss commented Jun 21, 2021

Makes more progress towards resolving #12091.

Adds

  • CheckTimeDistanceEquality
    • Ensures the distance between objects is consistent with the time between them
    • Applies to Easy and Normal difficulties
    • Leniency to allow for placing objects by hand approximately correct
    • Rolling window to allow building up/down slowly (e.g. for maps that change BPM and/or SV)
  • CheckLowDiffOverlaps
    • Ensures overlaps are done when appropriate
    • Applies to Easy difficulties
  • Tests for those checks
DunfnK0a2H.mp4

The overlap check should also apply to Normals, but only when they are the lowest difficulty in the set. I don't believe there's any way to detect that currently, given that the editor only knows of the difficulty being edited. So that's skipped for now.

Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major issues, nice work

@peppy peppy merged commit 6c3d231 into ppy:master Jun 22, 2021
@Naxesss Naxesss deleted the low-diff-checks branch November 3, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants