Add object duration checks #13874
Merged
Add object duration checks #13874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
requested changes
Jul 13, 2021
| /// </summary> | ||
| private const double leniency = 0.5d; | ||
|
|
||
| public CheckMetadata Metadata { get; } = new CheckMetadata(CheckCategory.Compose, "Zero-length hitobjects"); |
There was a problem hiding this comment.
Suggested change
| public CheckMetadata Metadata { get; } = new CheckMetadata(CheckCategory.Compose, "Zero-length hitobjects"); | |
| public CheckMetadata Metadata { get; } = new CheckMetadata(CheckCategory.Compose, "Zero-length objects"); |
We don't use the term "hitobject" anywhere in messages exposed to the user, as far as I can see.
There was a problem hiding this comment.
There are a few other checks where this term is used, like "unsnapped hitobjects", "concurrent hitobjects", "offscreen hitobjects", etc (these are meant to be exposed to the user at some point). I'd say if we want to change that it'll probably be best handled in that separate pass you mentioned on discord, as it will affect more than just this PR.
There was a problem hiding this comment.
Can probably happen when we add localisation support for all this stuff, if not sooner.
peppy
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes more progress on #12091
A little uncertain if we want
CheckTooShortSlidersandCheckTooShortSpinnersto be named so similarly considering one is a spread-dependent check and the other applies to any difficulty. We'll eventually want another too short spinner check that is specifically for spread (making sure beginners have enough time to spin and recover), so I could see this getting a bit confusing, but I'm not sure what else to call them at the moment.KG6kMU2iaG.mp4
The verify tab can now detect when sliders in easy difficulties are extremely short, when spinners are so short that auto can't achieve 1000 on them, and when objects somehow have a duration of 0 or less.