Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DatabaseBackedStore Prepare functions #1433

Merged
merged 2 commits into from
Oct 25, 2017
Merged

Remove DatabaseBackedStore Prepare functions #1433

merged 2 commits into from
Oct 25, 2017

Conversation

UselessToucan
Copy link
Contributor

@peppy
Copy link
Sponsor Member

peppy commented Oct 25, 2017

Does reset ever get called? I honestly think we can probably just remove those methods too..

@UselessToucan
Copy link
Contributor Author

Yes, there are no Reset calls. I will remove it since it looks that you don't mind.

@peppy peppy merged commit bf3b9e0 into ppy:master Oct 25, 2017
@UselessToucan UselessToucan deleted the DatabaseBackedStorePrepare branch October 25, 2017 13:18
@peppy peppy mentioned this pull request Nov 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UselessToucan @peppy