-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up User
class
#15466
Clean up User
class
#15466
Conversation
Unfortunately the getters need to be left in place else EF breaks.
So I started reviewing this, but I have a big problem with b9983ad. That commit generates 99% of this diff and contains multiple complications that were not explained anywhere, namely:
All of the above make reviewing this as-is a pretty dreadful experience because I'm basically discovering half of the satellite changes by browsing through a 200-file diff. If it's not too much trouble I'd much prefer that it was split to a separate pull, with split commits for each individual refactoring operation performed. Normally I wouldn't ask for this, but when the diffstat is 2k lines long... |
can split out those commits if you need. no real explanation though, just matching other recent changes |
I guess I could try and power through with the changes as they are but splitting that part better would make it a lot easier for me to review this. |
I managed to get a crash with this somewhere in the beatmap overlay, but the error was non-descript:
And I also couldn't repro it. So lgtm. |
Worrying, but hopefully not related to this PR alone... |
ToBeatmapInfo
/ToBeatmapSetInfo
#15463User
toAPIUser
and move to correct namespace #15505For now I haven't created a non-API version of this class (apart from the simple realm one). We can iterate on that if/when required.